Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Latvia card support #60

Merged
merged 1 commit into from
Sep 15, 2023
Merged

Update Latvia card support #60

merged 1 commit into from
Sep 15, 2023

Conversation

metsma
Copy link
Contributor

@metsma metsma commented Aug 7, 2023

WE2-811

Signed-off-by: Raul Metsma [email protected]

Copy link
Member

@mrts mrts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, excellent work as always - reading the key type from file is the most straight-forward and elegant way to handle this!

if (data.empty()) {
return {false, keyID};
}
static const byte_vector needle {0x02, 0x02, 0x00};
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

needle is vague, keyIDPattern tells what we are looking for. But let's fix it in the future.

WE2-811

Signed-off-by: Raul Metsma <[email protected]>
@mrts mrts merged commit 4436cc9 into web-eid:main Sep 15, 2023
5 checks passed
@metsma metsma deleted the lat branch September 18, 2023 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants