Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Czech eID card support #52

Merged
merged 1 commit into from
Sep 15, 2023
Merged

Czech eID card support #52

merged 1 commit into from
Sep 15, 2023

Conversation

mkmayer
Copy link
Contributor

@mkmayer mkmayer commented Jun 22, 2023 •
edited
Loading

Signed-off-by: Martin Mayer [email protected]

@Muzosh
Copy link

Muzosh commented Jun 22, 2023

Hello @mkmayer, how would you handle unverifiedCertificate verification in the authentication token on the back-end? Is this pull request intended only for limited number of entities in Czechia, that have access to intermediate certificate CAs? Or are there plans to release these state-issued public key certificates to the public?

@Muzosh
Copy link

Muzosh commented Jun 22, 2023 •
edited
Loading

I'm asking mainly because I would love to use state-issued electronic identities from Czech eIDs in non-official, Web-eID-enabled web applications myself :)

@metsma
Copy link
Contributor

metsma commented Jun 22, 2023

Please add signed off field to comment

github-advanced-security[bot]
github-advanced-security bot found potential problems Jun 22, 2023
View reviewed changes
src/electronic-ids/pkcs11/Pkcs11ElectronicID.cpp
@@ -99,6 +99,17 @@
return "/usr/lib/x86_64-linux-gnu/libbeidpkcs11.so.0";
#endif
}

inline fs::path czechPkcs11ModulePath()

Check notice

Code scanning / CodeQL

Unused static function Note

Static function czechPkcs11ModulePath is unreachable
@mkmayer
Copy link
Contributor Author

mkmayer commented Jun 22, 2023

I'm asking mainly because I would love to use state-issued electronic identities from Czech eIDs in non-official, Web-eID-enabled web applications myself :)

Unfortunately I don't know this. I am currently using the web-eid-js component to sign the hash. At the same time, I send the certificate returned from the getCertificate method to our backend X509, and a colleague from the backend can handle it. I don't know, maybe it has imported certificates on the backend, I can't tell. I'm sorry I can't help.

@Muzosh
Copy link

Muzosh commented Jun 22, 2023

Ok, thanks for the reply.

@mkmayer
Copy link
Contributor Author

mkmayer commented Jun 27, 2023

Hello guys, please, the merging itself makes somebody from your team? I don't have the Merge button here :(

@mrts
Copy link
Member

mrts commented Jun 27, 2023 •
edited
Loading

The merging must be officially approved by @kristelmerilain, she will voice her opinion soon. We must take into account the official release plans and schedule.

But it will be merged soon - thanks a lot for your contribution!

@mrts mrts merged commit 80a81b4 into web-eid:main Sep 15, 2023
4 checks passed
@mrts
Copy link
Member

mrts commented Sep 15, 2023

Merged, this will be part of the upcoming 2.5.0 release - thanks a lot for your contribution once more!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@klemensn klemensn klemensn left review comments

@mrts mrts mrts approved these changes

@metsma metsma metsma approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@mkmayer @Muzosh @metsma @mrts @klemensn