This repository has been archived by the owner on Dec 7, 2023. It is now read-only.
workflow: Upload release assets #719
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
darkowlzz
requested review from
chanwit,
luxas,
stealthybox and
twelho
as code owners
darkowlzz
force-pushed
the
release-assets-workflow
branch
from
9c70100
to
82777cb
Compare
Adds a workflow for automating the ignite and ignited binary releases. This builds the binaries with `make release` at a given tag and uploads them to a given tagged release. The release make target also builds the sandbox image and publishes it automatically with manifest list.
stealthybox
force-pushed
the
release-assets-workflow
branch
from
82777cb
to
a335147
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a workflow for automating the ignite and ignited binary releases.
This builds the binaries with
make releaseat a given tag and uploadsthem to a given tagged release. The release make target also builds the
sandbox image and publishes it automatically with manifest list.
This is a manual workflow, to be run after a release tag is created. Since
the existing release tool creates a temporary tag and removed it, this workflow
is intended to be run manually after running the release tools, once the final
tag is created. The only input is the release tag to checkout and update with
the release assets.
It uses https://github.com/svenstaro/upload-release-action for uploading the
assets, instead of the official github action https://github.com/actions/upload-release-asset
due to the limitations in uploading multiple files and lack of maintenance.
NOTE: Running
make releasefails in github actions environment due torunning docker run with
-itoption:For this workflow to work, docker should be run without that option. This is
not change in this PR yet.
Tested this on a fork https://github.com/darkowlzz/ignite/runs/1302989230?check_suite_focus=true
without docker run in interactive mode. The binaries were automatically posted
https://github.com/darkowlzz/ignite/releases/tag/v0.98.0 .