This repository has been archived by the owner on Dec 7, 2023. It is now read-only.
Add github action to update go dependencies #693
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is required to be able to update dependencies without usind docker in github actions. Vendoring the code-generation tools and running them with go run helps avoid running go get to install the tools and updating the mod file with unused dependencies.
Run `make go-autogen` and create a PR for any updated files. Schedule to run daily and also enable an option to trigger it manually on demand for creating PR that updates go dependencies. This uses branch `go-deps-patch` to create the PR and automatically deletes it once the PR is closed or merged.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a new github action to update go dependencies and create a PR with the changes.
The action is scheduled to run daily and can also be triggered manually from the github
actions tab. It uses branch
go-deps-patchfor creating PR.Github action can't run make target
autogen, which usesgo-in-dockerinternally due tothe interactive flags. It results in error:
To keep the existing behavior of
go-in-docker, this PR changesgo-autogento workoutside of container environment.
go-autogenmake target expects the code generation tools to be available in/go/bin/. Thisisn't true when running without the docker environment created by
go-in-dockertarget.To be able to run the code generation along with dependency updates on host directly, vendor
the code generation tools using the tools.go approach.
Refer https://github.com/golang/go/wiki/Modules#how-can-i-track-tool-dependencies-for-a-module
This helps avoid changing the mod file while installing the tools with go get and the need to
perform a cleanup at the end. It helps ensure that the vendored code-generation tools will always
reproduce the same results for everyone.