Skip to content
This repository has been archived by the owner on Dec 7, 2023. It is now read-only.

update instructions to latest #502

Merged
merged 1 commit into from
Dec 11, 2019
Merged

update instructions to latest #502

merged 1 commit into from
Dec 11, 2019

Conversation

dholbach
Copy link
Contributor

fixes: #496

@dholbach dholbach requested review from chanwit and removed request for twelho December 11, 2019 14:45
@chanwit
Copy link
Member

chanwit commented Dec 11, 2019

thank you for this PR @dholbach
a few change to reflect the new version of Firecracker :-)

chanwit
chanwit approved these changes Dec 11, 2019
View reviewed changes
docs/installation.md Outdated Show resolved Hide resolved
@dholbach
Copy link
Contributor Author

dholbach commented Dec 11, 2019 •
edited
Loading

Might be worth automating this somehow? Maybe a sed -i in a release script somewhere? :-)

@chanwit
Copy link
Member

chanwit commented Dec 11, 2019

LGTM

@chanwit chanwit merged commit 9713f37 into weaveworks:master Dec 11, 2019
@chanwit
Copy link
Member

chanwit commented Dec 11, 2019

Thank you @dholbach :-) :-) :-)

@dholbach dholbach deleted the fix-496 branch December 11, 2019 15:07
@stealthybox
Copy link
Contributor

AAAAAHHH I'm always forgetting to bump this number before I release >_>

We need add this to the doc generation

@luxas luxas added this to the v0.7.0 milestone Jun 2, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@chanwit chanwit chanwit approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.7.0
Development

Successfully merging this pull request may close these issues.

Installation instructions broken with 0.6.x release being latest
4 participants
@dholbach @chanwit @stealthybox @luxas