This repository has been archived by the owner on Dec 7, 2023. It is now read-only.
use ssh discover technique to check if SSH service is really run… #469
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is unfortunately even slower than before. time sudo ignite-v0.6.1 run weaveworks/ignite-ubuntu --ssh
INFO[0000] Created VM with ID "352579ed0c948d0e" and name "broken-dew"
INFO[0001] Networking is handled by "cni"
INFO[0001] Started Firecracker VM "352579ed0c948d0e" in a container with ID "ignite-352579ed0c948d0e"
sudo ignite-v0.6.1 run weaveworks/ignite-ubuntu --ssh 0.19s user 0.14s system 9% cpu 3.496 total
time sudo ./bin/ignite run weaveworks/ignite-ubuntu --ssh
INFO[0000] Created VM with ID "67548738f4251506" and name "blue-snowflake"
INFO[0001] Networking is handled by "cni"
INFO[0001] Started Firecracker VM "67548738f4251506" in a container with ID "ignite-67548738f4251506"
sudo ./bin/ignite run weaveworks/ignite-ubuntu --ssh 0.21s user 0.15s system 6% cpu 5.751 total |
stealthybox
added a commit
that referenced
this pull request
Oct 8, 2019
…ally run… (#469) use ssh discover technique to check if SSH service is really running
stealthybox
added a commit
that referenced
this pull request
Oct 8, 2019
use ssh discover technique to check if SSH service is really running
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves the SSH wait mechanism by trying to authen the SSH server of a VM.
If the SSH returns "unable to authen" then it seems to be really up and running.
Thank you @lucidprogrammer who found this bug on his baremetal box.
I also found this bug too when running Ignite on a very machine.
@stealthybox this seems to be an urgent fix needed by tmr event.
and we also need it for v0.5.5.