This repository has been archived by the owner on Dec 7, 2023. It is now read-only.
make rm command more robust with addition check #413
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Chanwit Kaewkasi <[email protected]>
stealthybox
approved these changes
Sep 9, 2019
| if err := cleanup.DeactivateSnapshot(vm); err != nil { | ||
| return err | ||
| // After remove the VM container, and the SnapshotDev still there | ||
| if _, err := os.Stat(vm.SnapshotDev()); err == nil { |
There was a problem hiding this comment.
The fact that we have to do this is a code-smell.
I have a feeling we need to look at how we store vm state.
It's a bit weird that we could run this Cleanup function and not know whether there is a container or snapshot to delete.
There was a problem hiding this comment.
indeed.
we need to take a look into the mechanism of the vm removal process.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Snapshot dev leak happens randomly after
rm -f, but sometime it won't.The default behavior of
rm -fworks mostly correct. So that the snapshot dev will be removed afterRemoveVMContainer. However, there are some glitches reported by #365 and we merged #381 to fix it.Unfortunately, cleanup in PR #381 add an extra step. If the
RemoveVMContainerworks correctly, there's no mapping device left to remove. So an error occurred andrm -freturned non-zero. This PR adds more check to correct that behavior.Signed-off-by: Chanwit Kaewkasi [email protected]