Move from SecCertificateCopyPublicKey(_:) to SecCertificateCopyKey(_:) in macOS 10.14+ #67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wbond
added a commit
that referenced
this pull request
Sep 30, 2022
|
Thanks for your work on this! Can you see if the test fails for you on an M1 with 222a558? I grabbed the cert you had in this PR and added it as a test to make sure we have a failing test to rely on. This PR is effectively the same as #63, although this adds some IDE configuration (which we wouldn't want), and bumps the version prematurely, and incompletely. |
|
Alright, this should be fixed on master |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for issue #66