Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove .hash_algo for EdDSA-based signature algorithms #265

Merged
merged 1 commit into from
Sep 27, 2023
Merged

Remove .hash_algo for EdDSA-based signature algorithms #265

merged 1 commit into from
Sep 27, 2023

Conversation

wbond
Copy link
Owner

@wbond wbond commented Sep 1, 2023

Add .cms_hash_algo as a replacement. See discussion at #230 for details.

@wbond
Remove .hash_algo for ECDSA-based signature algorithms
a26e04d 
Add .cms_hash_algo as a replacement. See discussion at
#230 for details.
@wbond wbond mentioned this pull request Sep 1, 2023
Closed
@MatthiasValvekens
Copy link
Contributor

MatthiasValvekens commented Sep 2, 2023 •
edited
Loading

LGTM, with two one minor remarks (I can't self-request a review here, apparently).

  • typo in the commit message/PR title (ECDSA -> EdDSA)
  • are you sure you don't want a ValueError as the default/unknown case in cms_hash_algo, if only for consistency with hash_algo? Never mind, I misread the diff

@wbond wbond changed the title Remove .hash_algo for ECDSA-based signature algorithms Remove .hash_algo for EdDSA-based signature algorithms Sep 27, 2023
@wbond wbond merged commit 3c903c8 into master Sep 27, 2023
53 checks passed
@dotlambda dotlambda mentioned this pull request Feb 7, 2024
Open
@Moraxyc Moraxyc mentioned this pull request May 27, 2024
Closed
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wbond @MatthiasValvekens