Add hooks for blacklist/whitelist regexs for graphite listener #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| null : Pattern.compile(pointLineBlackListRegex); | ||
|
|
||
| this.regexTimer = Metrics.newTimer( | ||
| new MetricName("validationRegex." + String.valueOf(port), "", "microsecs"), |
There was a problem hiding this comment.
I don't think we really need to time regex speeds :)
There was a problem hiding this comment.
I think this is just in case there's something ridiculous (Sam was a bit worried that we couldn't predict the compute expense of the regex that the customer supplies)
(But probably the metric machinery might be as expensive as the regex =P, so I could take it out if you want )
There was a problem hiding this comment.
Yeah, the timer is efficient but not free. If they have a problem, I think we can just ask them to give us the regex and we'd know (probably right away) whether it's a problem or not. Tracking every call seems a bit heavy.
ff1c1d7
to
e83487b
Compare
|
repushed |
panghy
added a commit
that referenced
this pull request
Aug 31, 2015
Add hooks for blacklist/whitelist regexs for graphite listener
thepeterstone
referenced
this pull request
in thepeterstone/wavefront-proxy
Jan 24, 2022
sbhakta-vmware
added a commit
that referenced
this pull request
Sep 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@panghy
Trying again