-
Notifications
You must be signed in to change notification settings - Fork 139
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update README.md #9
Conversation
Hi, Spent quiet a few time to fail to announce non standard service. Hope this may help someone else !
@mh-cbon did you try to announce an official service listed on the IANA list, but with a wrong port? Or did you want to make your own custom service name not listed on the IANA list? |
Hi, I tried to announce Does the port number matters too ? I have not noticed that. I was playing around the service type only. |
@mh-cbon I'm not sure what you mean by that you tried to advertise it on your router. Did you install this module on your router? You network doesn't care about the name or the port number. Your router should happily broadcast whatever your send to it to everyone on the network. It's up to the clients whether or not they will accept it. Say you create a new type of video server. You call it "Foobar Videos" and you want to advertise it on the network under the name |
@mh-cbon in regards to weather or not the port is important, that will be up to the client. If the client is really picky about the port then it matters, but plenty of service types doesn't care. E.g. all the |
@mh-cbon btw, don't get me wrong here. I think it's good to mention the link you added to the readme 😃 - it's a good resource for people to know about. I just don't think it should be required that they use one from the list... it should be optional I think. That's why I'm trying to figure out what problem you experienced 😃 |
Hi ! Yeah agreed, a simple mention is better. See how i proceeded,
Terminal 2
Terminal 1 won t show the new service. I guess it s because my router is picky about the service type. Now if i announce an
That works fine for Seems my router won t allow that. In the end, it just mean i will rely on service name field to id my service type ;) |
I tried an update, but my english is non standard too, you may want to refactor for clarity and correctness : ) |
Thanks for explaining 😃 To me it seems extremely weird that your router should even care the slightest about this. Your router just passes on this sort of DNS packets. It doesn't validate it - it would have no idea how. Also, according to the RFC, it's perfectly ok to make up your own names, so your router would be in violation of the RFC if it did block. I think something else is going on here - maybe a bug in either |
@mh-cbon merged 😃 Thanks for contributing to the project! |
I really believe the router does block it, found this tool on my box here which gives same results as your impl. of bonjour,
Thanks for publishing it initially ! That s least i can do :) |
Thnx, I'll see if I can reproduce it |
Hi,
Spent quiet a few time to fail to announce non standard service.
Hope this may help someone else !