Add A & AAAA record support #12
Conversation
|
@jlucidar Thanks a lot for the pull request 😃 There's a few tests that are failing related to styling. Please update the styling to match the styling used so that the tests parse. |
|
Hi @watson, |
| @@ -135,6 +151,7 @@ test('bonjour.findOne - emitter', function (bonjour, t) { | |||
| var browser = bonjour.findOne({ type: 'test' }) | |||
| browser.on('up', function (s) { | |||
| t.equal(s.name, 'Emitter') | |||
| browser.stop() | |||
There was a problem hiding this comment.
How come you added the browser.stop() calls a few places? Did the event loop hang?
There was a problem hiding this comment.
no, it was one of my tentative to fix a bug that I didn't clear ... I can remove it if you want me to.
for whatever reason, the buildServicesFor function acted weirdly during the test; it was pushing duplicate addresses to the addresses field.
I resolved it, but I can't really explain why it was doing that.
There was a problem hiding this comment.
no problem - I removed it my self :)
|
@jlucidar thanks again for the PR 😄 It's now published as v3.4.0 on npm |
If you register a new service, the addresses' field of your service is now being populated with the IP addresses of the machine.