Add binary txt option. #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@kkushimoto Thanks for PR 😃 Just a quick question: I'm really curious of your use case with binary TXT records. Do you mind sharing it? |
| } else { | ||
| this._name = serviceName.stringify(opts.type, opts.protocol || 'tcp') + TLD | ||
| if (opts.name) this._name = opts.name + '.' + this._name | ||
| this._wildcard = false | ||
| if (!opts.txt || !opts.txt.binary) { |
There was a problem hiding this comment.
In case the txt property is given, why not just pass it into the dnsTxt constructor as it is?
|
Thank you for reviewing my PR.
I want to find a service that publish binary value txt. I'm not good at English 😓 |
|
@kkushimoto Ups, didn't see your response before now. I've merged your pull request and it's now published as v3.4.0 on npm |
|
Thank you so much! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.