Enforce proper DNS host comparison

Closes #6

lib/browser.js

@@ -3,6 +3,7 @@
 var util = require('util')
 var EventEmitter = require('events').EventEmitter
 var serviceName = require('multicast-dns-service-types')
+var dnsEqual = require('dns-equal')
 var txt = require('mdns-txt')()
 
 var TLD = '.local'
@@ -75,22 +76,22 @@ Browser.prototype._addService = function (service) {
 Browser.prototype._removeService = function (fqdn) {
  var service, index
  this.services.some(function (s, i) {
- if (s.fqdn === fqdn) {
+ if (dnsEqual(s.fqdn, fqdn)) {
  service = s
  index = i
  return true
  }
  })
  if (!service) return
  this.services.splice(index, 1)
- this._serviceMap[fqdn] = false
+ delete this._serviceMap[fqdn]
  this.emit('down', service)
 }
 
 function goodbyes (name, packet) {
  return packet.answers.concat(packet.additionals)
  .filter(function (rr) {
- return rr.name === name && rr.type === 'PTR' && rr.ttl === 0
+ return dnsEqual(rr.name, name) && rr.type === 'PTR' && rr.ttl === 0
  })
  .map(function (rr) {
  return rr.data
@@ -104,7 +105,7 @@ function buildServicesFor (name, packet) {
 
  return records
  .filter(function (rr) {
- return rr.name === name && rr.type === 'PTR'
+ return dnsEqual(rr.name, name) && rr.type === 'PTR'
  })
  .map(function (ptr) {
  var service = {
@@ -113,7 +114,7 @@ function buildServicesFor (name, packet) {
 
  records
  .filter(function (rr) {
- return rr.name === ptr.data && (rr.type === 'SRV' || rr.type === 'TXT')
+ return dnsEqual(rr.name, ptr.data) && (rr.type === 'SRV' || rr.type === 'TXT')
  })
  .forEach(function (rr) {
  if (rr.type === 'SRV') {
@@ -135,7 +136,7 @@ function buildServicesFor (name, packet) {
 
  records
  .filter(function (rr) {
- return rr.name === service.host && (rr.type === 'A' || rr.type === 'AAAA')
+ return dnsEqual(rr.name, service.host) && (rr.type === 'A' || rr.type === 'AAAA')
  })
  .forEach(function (rr) {
  service.addresses.push(rr.data)

lib/mdns-server.js

@@ -1,6 +1,7 @@
 'use strict'
 
 var multicastdns = require('multicast-dns')
+var dnsEqual = require('dns-equal')
 var flatten = require('./flatten')
 
 module.exports = Server
@@ -83,7 +84,7 @@ Server.prototype._recordsFor = function (name, type) {
  if (name) {
  return self.registry[type].filter(function (record) {
  var _name = ~name.indexOf('.') ? record.name : record.name.split('.')[0]
- return _name === name
+ return dnsEqual(_name, name)
  })
  } else {
  return self.registry[type]

package.json

@@ -4,6 +4,7 @@
  "description": "A Bonjour/Zeroconf implementation in pure JavaScript",
  "main": "index.js",
  "dependencies": {
+ "dns-equal": "^1.0.0",
  "mdns-txt": "^2.0.0",
  "multicast-dns": "^5.0.0",
  "multicast-dns-service-types": "^1.1.0"