Improve filtering in browser

watson · Jan 23, 2016 · aea960b · aea960b
1 parent b0c7842
commit aea960b
Showing 1 changed file with 4 additions and 4 deletions.
diff --git a/lib/browser.js b/lib/browser.js
@@ -91,7 +91,7 @@ Browser.prototype._removeService = function (fqdn) {
 function goodbyes (name, packet) {
  return packet.answers.concat(packet.additionals)
  .filter(function (rr) {
- return dnsEqual(rr.name, name) && rr.type === 'PTR' && rr.ttl === 0
+ return rr.type === 'PTR' && rr.ttl === 0 && dnsEqual(rr.name, name)
  })
  .map(function (rr) {
  return rr.data
@@ -105,7 +105,7 @@ function buildServicesFor (name, packet) {
 
  return records
  .filter(function (rr) {
- return dnsEqual(rr.name, name) && rr.type === 'PTR'
+ return rr.type === 'PTR' && dnsEqual(rr.name, name)
  })
  .map(function (ptr) {
  var service = {
@@ -114,7 +114,7 @@ function buildServicesFor (name, packet) {
 
  records
  .filter(function (rr) {
- return dnsEqual(rr.name, ptr.data) && (rr.type === 'SRV' || rr.type === 'TXT')
+ return (rr.type === 'SRV' || rr.type === 'TXT') && dnsEqual(rr.name, ptr.data)
  })
  .forEach(function (rr) {
  if (rr.type === 'SRV') {
@@ -136,7 +136,7 @@ function buildServicesFor (name, packet) {
 
  records
  .filter(function (rr) {
- return dnsEqual(rr.name, service.host) && (rr.type === 'A' || rr.type === 'AAAA')
+ return (rr.type === 'A' || rr.type === 'AAAA') && dnsEqual(rr.name, service.host)
  })
  .forEach(function (rr) {
  service.addresses.push(rr.data)