Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: stop breaking Llama 2 conversational search answers on double newlines #214

Merged
merged 1 commit into from
Oct 9, 2023
Merged

fix: stop breaking Llama 2 conversational search answers on double newlines #214

merged 1 commit into from
Oct 9, 2023

Conversation

anirudhaBapat
Copy link
Contributor

ethanwinters
ethanwinters approved these changes Oct 9, 2023
View reviewed changes
Copy link
Member

@ethanwinters ethanwinters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm just approving so you are not blocked from merging when someone reviews. I DID NOT REVIEW.

@jwm4 jwm4 self-assigned this Oct 9, 2023
jwm4
jwm4 approved these changes Oct 9, 2023
View reviewed changes
Copy link
Member

@jwm4 jwm4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have tested this and verified that it works. The changes to the README look good. Thanks!

@jwm4 jwm4 merged commit a1530db into watson-developer-cloud:master Oct 9, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jwm4 jwm4 jwm4 approved these changes

@ethanwinters ethanwinters ethanwinters approved these changes

Assignees

@jwm4 jwm4

Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@anirudhaBapat @jwm4 @ethanwinters @anibapat