Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(watsonx generic starter kit): make use of API key instead of bearer token(which expires in 60 mins & needs a renewal) #179

Merged

Conversation

anirudhaBapat
Copy link
Contributor

What is included in this PR?

  • Update to openAPI spec file which makes use of OAuth2 custom flow auth type instead of existing bearer token which expires in 60 mins
  • Updated actions.json file to match with the new openAPI spec hash
  • Readme file changes to list new instructions for using auth.

…er token(which expires in 60 mins & needs a renewal)
Copy link
Member

@jwm4 jwm4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look good to me, but I want to test them in prod after the OAuth support is in prod before we merge this. I will do that and submit a new review.

@@ -629,8 +629,8 @@
"type": "integration_interaction",
"method": "POST",
"internal": {
"spec_hash_id": "efd13c68dff079388ffa62bfc3aff447e49efd7024450961cc74d6de89106cce",
"catalog_item_id": "f53a6acc-4505-45a5-a785-27fe357b96da"
"spec_hash_id": "572393bac5639f3adad43d3d7cc830fc3575568d094fa2bb634d33e62f83f0a5",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The autoconfig is not working for me. The value I am getting for spec_hash_id is:

cc50493e455de183d661b95360196ddb468a02051add6dcaf4a6479b34900be5

So I think this action file is made with an older version of the OpenAPI spec.

Copy link
Member

@jwm4 jwm4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is working now and looks good.

@jwm4 jwm4 marked this pull request as ready for review July 26, 2023 13:19
@jwm4 jwm4 merged commit 3f83c7f into watson-developer-cloud:master Jul 26, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants