fix(spotify): fixing invalid spec #130
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ethanwinters
force-pushed
the
fix-spotify-spec
branch
from
628ef0d
to
e7dcbb0
Compare
Stricter validation of OpenAPI specs uncovered some errors in this spec.
ethanwinters
force-pushed
the
fix-spotify-spec
branch
from
e7dcbb0
to
2aa6d1e
Compare
ethanwinters
commented
Jun 8, 2023
| "type": "object", | ||
| "properties": { | ||
| "track": { | ||
| "type": "object", |
There was a problem hiding this comment.
This schema gets pretty big and crazy, so leaving it as "object".
anirudhaBapat
approved these changes
Jun 30, 2023
arrraichu
approved these changes
Jul 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stricter validation of OpenAPI specs uncovered some errors in this spec around using object patterns for arrays (using "properties" instead of "items"). Also run linting to fix formatting issues.