spicyTuna/feature/image-upload #146
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PGrad
reviewed
May 23, 2023
There was a problem hiding this comment.
Hey Luke, thanks for making this API for image upload. I've got some feedback:
- Would it be possible to move the db credentials into a secrets file? Generally it's good practice to not include credentials in code.
- Can you add a route that allows me to fetch images associated with a given tree?
- Please make sure to run the linter on your code (and follow the Code Conventions here).
zoobot
reviewed
Jul 13, 2023
|
|
||
| //Change the route to 'idk' just change from filenumber | ||
| treeimagesRouter.get('/treeimage/:filenumber', async (req, res) => { | ||
| const { idImage, tree_images } = req.query; |
There was a problem hiding this comment.
We need to add id as a parameter for the tree since its getting images for that specific tree
zoobot
reviewed
Jul 13, 2023
| const { idImage, tree_images } = req.query; | ||
|
|
||
| if (!idImage && tree_images === 'All') { | ||
| let foundImages = await getAllImages(); |
PGrad
reviewed
Jul 13, 2023
| imageuploadRouter.get('/image/:filename', (req, res) => { | ||
| const loaded = false; | ||
| const { filename } = req.params; | ||
| if(loaded === false){ |
There was a problem hiding this comment.
@Spicytuna24 is this if statement supposed to be here? I see you're checking if loaded is false when it was already set as such two lines above.
There was a problem hiding this comment.
That'd old and I need to remove that
zoobot
reviewed
Jul 20, 2023
| const dataInSnakeCase = convertObjectKeysToSnakeCase(source); | ||
|
|
||
| const query = ` | ||
| INSERT INTO tree_images(\${this:name}) |
There was a problem hiding this comment.
This needs to be create image where id is specific id
zoobot
reviewed
Jul 20, 2023
| return results; | ||
| } | ||
|
|
||
| export async function getAllImages() { |
There was a problem hiding this comment.
will also need a getAllImagesById query
Spicytuna24
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added the backend route for the image upload feature. Needs the database table name and route name.