Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ESLint issues (Errors) - no-unreachable, no-unused-vars, no-undef #110

Merged

Conversation

jazhen
Copy link
Contributor

@jazhen jazhen commented Oct 30, 2022

Fix all errors under the category no-unreachable, no-unused-vars, and no-undef.

List of issues (May not be exhaustive so double check):

  • wtt_server/server/routes/treeadoptions/treeadoptions-router.js
    • 20:5 error Unreachable code no-unreachable
  • wtt_server/server/routes/treeadoptions/treeadoptions.test.js
    • 208:15 error 'adoptedTree' is assigned a value but never used no-unused-vars
  • wtt_server/server/routes/treeid/treeid-test.js
    • 2:8 error 'faker' is defined but never used no-unused-vars
  • wtt_server/server/routes/treeid/treeid-validations.js
    • 7:7 error 'state' is not defined no-undef
  • wtt_server/server/routes/treelikes/treelikes.test.js
    • 205:15 error 'likedTree' is assigned a value but never used no-unused-vars

Closes #109

Fix all errors under the category
no-unreachable, no-unused-vars, and no-undef.

Closes #109
@jazhen jazhen force-pushed the jazhen/fix/eslint-no-unreachable-no-unused-vars-no-undef branch from 086cec8 to bb31553 Compare October 30, 2022 19:33
Copy link
Member

@zoobot zoobot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice thanks!

@zoobot zoobot merged commit 2d4d4f4 into main Oct 30, 2022
@jazhen jazhen deleted the jazhen/fix/eslint-no-unreachable-no-unused-vars-no-undef branch October 30, 2022 21:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Fix ESLint issues (Errors) - no-unreachable, no-unused-vars, no-undef
2 participants