Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ESLint import/no-commonjs issues #108

Merged
merged 1 commit into from
Oct 30, 2022

Conversation

jazhen
Copy link
Contributor

@jazhen jazhen commented Oct 30, 2022

Fix all warnings under the category import/no-commonjs.

List of issues:

  • wtt_server/ecosystem.config.js
    • 1:1 warning Expected "export" or "export default" import/no-commonjs
  • wtt_server/server/utilities/remove-duplicate-trees.js
    • 3:16 warning Expected "import" instead of "require()" import/no-commonjs
  • wtt_server/server/utilities/update-ids.js
    • 2:16 warning Expected "import" instead of "require()" import/no-commonjs
    • 3:23 warning Expected "import" instead of "require()" import/no-commonjs

closes #107

Copy link

@vernfongchao vernfongchao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

@vernfongchao vernfongchao merged commit 4e81c51 into main Oct 30, 2022
@zoobot zoobot deleted the jazhen/fix/eslint-importno-commonjs branch October 30, 2022 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Fix ESLint issues (Warnings) - import/no-commonjs
2 participants