Add/remove comments

server/routes/users/users-controller.js

@@ -44,7 +44,6 @@ export function buildUsersController({ usersService }) {
  };
 
  function buildGetRequestUserDTO({ query: { email } }) {
- // maybe do these existence validations in a middleware
  if (!email) {
  throw new AppError(400, 'Missing required parameter: email.');
  }
@@ -57,7 +56,6 @@ export function buildUsersController({ usersService }) {
  }
 
  function buildPostRequestUserDTO({ body: { email, name, nickname } }) {
- // maybe do these existence validations in a middleware
  if (!email) {
  throw new AppError(400, 'Missing required parameter: email.');
  }

server/routes/users/users-service.js

@@ -1,11 +1,15 @@
 export const buildUsersService = ({ usersRepository }) => {
  return {
  async getUser({ userDTO: { email } }) {
- // validate business logic of email
+ // validate business logic here
+ // check if userDTO.email is an email
+ // if not, throw error?
  return usersRepository.findUser({ email });
  },
  async createUser({ userDTO }) {
- // validate business logic of userDTO fields
+ // validate business logic here
+ // add check that the fields in userDTO are valid to add to the database
+ // this will help prevent irregular data from sneaking into our database
  return usersRepository.createUser({ user: userDTO });
  },
  };