Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ESLint issues (Errors) - no-unreachable, no-unused-vars, no-undef #109

Closed
10 tasks
jazhen opened this issue Oct 30, 2022 · 0 comments · Fixed by #110
Closed
10 tasks

Fix ESLint issues (Errors) - no-unreachable, no-unused-vars, no-undef #109

jazhen opened this issue Oct 30, 2022 · 0 comments · Fixed by #110
Assignees
@jazhen
Labels
backend

Comments

@jazhen
Copy link
Contributor

jazhen commented Oct 30, 2022

Running npm run lint in the command line shows various ESLint issues that we should fix. The issues are split into warnings (yellow-coded) and errors (red-coded). Within warnings and errors, the issues are split into categories by ESLint rule name.

Example: image

Fix all warnings under the category ino-unreachable, no-unused-vars, and no-undef. Please make sure to regression test so that we know nothing has broken through these changes.

List of issues (May not be exhaustive so double check):

  • wtt_server/server/routes/treeadoptions/treeadoptions-router.js
    • 20:5 error Unreachable code no-unreachable
  • wtt_server/server/routes/treeadoptions/treeadoptions.test.js
    • 208:15 error 'adoptedTree' is assigned a value but never used no-unused-vars
  • wtt_server/server/routes/treeid/treeid-test.js
    • 2:8 error 'faker' is defined but never used no-unused-vars
  • wtt_server/server/routes/treeid/treeid-validations.js
    • 7:7 error 'state' is not defined no-undef
  • wtt_server/server/routes/treelikes/treelikes.test.js
    • 205:15 error 'likedTree' is assigned a value but never used no-unused-vars
@jazhen jazhen self-assigned this Oct 30, 2022
jazhen added a commit that referenced this issue Oct 30, 2022
@jazhen
Fix ESLint Errors
086cec8 
Fix all errors under the category
no-unreachable, no-unused-vars, and no-undef.

Closes #109
@jazhen jazhen mentioned this issue Oct 30, 2022
Merged
10 tasks
@jazhen jazhen linked a pull request Oct 30, 2022 that will close this issue
Fix ESLint issues (Errors) - no-unreachable, no-unused-vars, no-undef #110
Merged
10 tasks
jazhen added a commit that referenced this issue Oct 30, 2022
@jazhen
Fix ESLint Errors
bb31553 
Fix all errors under the category
no-unreachable, no-unused-vars, and no-undef.

Closes #109
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jazhen jazhen

Labels
backend
Projects
Water the Trees
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix ESLint issues (Errors) - no-unreachable, no-unused-vars, no-undef waterthetrees/wtt_server
1 participant
@jazhen