Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ESLint issues (Warnings) - import/no-commonjs #107

Closed
7 tasks
jazhen opened this issue Oct 30, 2022 · 0 comments · Fixed by #108
Closed
7 tasks

Fix ESLint issues (Warnings) - import/no-commonjs #107

jazhen opened this issue Oct 30, 2022 · 0 comments · Fixed by #108
Assignees
Labels

Comments

@jazhen
Copy link
Contributor

jazhen commented Oct 30, 2022

Running npm run lint in the command line shows various ESLint issues that we should fix. The issues are split into warnings (yellow-coded) and errors (red-coded). Within warnings and errors, the issues are split into categories by ESLint rule name.

Example: image

Fix all warnings under the category import/no-commonjs . Please make sure to regression test so that we know nothing has broken through these changes.

List of issues (May not be exhaustive so double check):

  • wtt_server/ecosystem.config.js
    • 1:1 warning Expected "export" or "export default" import/no-commonjs
  • wtt_server/server/utilities/remove-duplicate-trees.js
    • 3:16 warning Expected "import" instead of "require()" import/no-commonjs
  • wtt_server/server/utilities/update-ids.js
    • 2:16 warning Expected "import" instead of "require()" import/no-commonjs
    • 3:23 warning Expected "import" instead of "require()" import/no-commonjs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

1 participant