Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #635 - Image header for profile page (design) #783

Open
wants to merge 19 commits into
base: main
Choose a base branch
from

Conversation

drumwolf
Copy link
Collaborator

@drumwolf drumwolf commented Dec 7, 2023

Issue:
#635

Before:
Screenshot 2023-12-06 at 7 25 32 PM

After:
Screenshot 2023-12-06 at 7 25 24 PM

// margin: 0 3em 0 2em;
// }
// }

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@drumwolf I think you forgot to remove this commented code

Copy link
Member

@zoobot zoobot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding, Looks nicer.

Do you have time to add a test snapshot or add that to the next round?
Examples are in the tests folder: https://github.com/waterthetrees/wtt_front/tree/main/client/src/tests

@drumwolf drumwolf requested a review from zoobot January 4, 2024 03:40
@drumwolf
Copy link
Collaborator Author

drumwolf commented Jan 4, 2024

@zoobot Ready to go.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants