Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change id to id_name in sources/crosswalk, Change ref to id_reference… #50

Merged
merged 10 commits into from
Mar 21, 2023
Merged

Change id to id_name in sources/crosswalk, Change ref to id_reference… #50

merged 10 commits into from
Mar 21, 2023

Conversation

zoobot
Copy link
Member

@zoobot zoobot commented Feb 14, 2023

…, drop id_city_name

@zoobot zoobot marked this pull request as draft February 14, 2023 16:36
@zoobot zoobot mentioned this pull request Feb 17, 2023
Open
6 tasks
@zoobot zoobot marked this pull request as ready for review March 14, 2023 19:06
This was referenced Mar 14, 2023
Merged
Merged
@zoobot
Copy link
Member Author

zoobot commented Mar 14, 2023

The new source route is ready to go, requires all these PRs to go in at once. Thanks for looking.
You can run server tests with npm test -- sources.test.js
Front end snapshot tests with npm test

#50

waterthetrees/wtt_front#401

waterthetrees/wtt_server#126

@zoobot zoobot requested a review from mwpark2014 March 14, 2023 19:18
mwpark2014
mwpark2014 reviewed Mar 18, 2023
View reviewed changes
Copy link

@mwpark2014 mwpark2014 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have much context, but I left some comments. Overall looks good to me, but the changes look a bit risky right before the demo this wed. Are you looking to merge in this weekend?

tables/public.treedata.sql Show resolved Hide resolved
migrations/2023-02-14-migration.sql Show resolved Hide resolved
2023-02-16_2018_sources.sql Outdated Show resolved Hide resolved
@zoobot
Copy link
Member Author

zoobot commented Mar 20, 2023

I don't have much context, but I left some comments. Overall looks good to me, but the changes look a bit risky right before the demo this wed. Are you looking to merge in this weekend?

We can leave it out until after the demo. I don't know that they will care too much about this since they likely have one data source and it sounds like its not on a public url.

@zoobot
Copy link
Member Author

zoobot commented Mar 20, 2023

This is ready to go. Thanks for reviewing!!

@zoobot zoobot merged commit 07600ed into main Mar 21, 2023
@zoobot zoobot deleted the zoobot/patch/migration-sources branch March 21, 2023 15:04
@zoobot zoobot mentioned this pull request Mar 26, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mwpark2014 mwpark2014 mwpark2014 left review comments

@tzinckgraf tzinckgraf tzinckgraf approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Sources Integration with FE and vector tiles and db
3 participants
@zoobot @tzinckgraf @mwpark2014