Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

30-add-table-schemas #44

Merged
merged 2 commits into from
Jan 4, 2023
Merged

30-add-table-schemas #44

merged 2 commits into from
Jan 4, 2023

Conversation

tzinckgraf
Copy link
Contributor

  • added a script to fetch the tables dynamically and pull schemas into files
  • added the table schema for individual tables

@tzinckgraf
30-add-table-schemas
98ee369 
- added a script to fetch the tables dynamically and pull schemas into
files
- added the table schema for individual tables
@tzinckgraf tzinckgraf requested a review from zoobot January 4, 2023 03:14
zoobot
zoobot approved these changes Jan 4, 2023
View reviewed changes
Copy link
Member

@zoobot zoobot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks!
Can you add documentation in the README with a note to make sure to run the fetch-tables script for every migration so this stays up to date?
Go ahead and merge once that's done.

@zoobot zoobot linked an issue Jan 4, 2023 that may be closed by this pull request
wtt_db -- Schema sql and documentation for all tables #30
Closed
@tzinckgraf
30-add-table-schemas
e37e012 
- updated README with database update instructions
@tzinckgraf
Copy link
Contributor Author

@zoobot I updated the README with instructions on making database updates, including running the script. Let me know if this is good.

zoobot
zoobot approved these changes Jan 4, 2023
View reviewed changes
Copy link
Member

@zoobot zoobot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks

@zoobot zoobot merged commit 2121054 into main Jan 4, 2023
@zoobot zoobot deleted the 30-add-table-schemas branch January 18, 2023 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zoobot zoobot zoobot approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Water the Trees
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

wtt_db -- Schema sql and documentation for all tables
2 participants
@tzinckgraf @zoobot