Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature/command-line-sources-args #23

Merged
merged 1 commit into from
Feb 21, 2023
Merged

Conversation

tzinckgraf
Copy link
Contributor

Add command line arguments with yargs.
The only argument so far is a --sources argument, which is a list of sources based on the source id. This is very useful for testing instead of worrying about processing all files.

The command line arguments are added to the config in a variable called ARGS, then later get called when pulling the sources. The change for the different ETL steps is seamless as a result.

Remove a copy-paste import

fixed up a less readable variable name

Add command line arguments with yargs.
The only argument so far is a --sources argument, which is a list of
sources based on the source id. This is very useful for testing instead
of worrying about processing all files.

The command line arguments are added to the config in a variable called
`ARGS`, then later get called when pulling the sources. The change for
the different ETL steps is seamless as a result.

Remove a copy-paste import

fixed up a less readable variable name
Copy link
Member

@zoobot zoobot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Nice work, thanks for all your contributions!

@zoobot zoobot merged commit 87b0b98 into main Feb 21, 2023
@zoobot zoobot deleted the feature/command-line-sources-args branch February 21, 2023 03:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants