Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Zoobot/patch/crosswalk fixes #17

Merged
merged 6 commits into from
Feb 8, 2023
Merged

Zoobot/patch/crosswalk fixes #17

merged 6 commits into from
Feb 8, 2023

Conversation

zoobot
Copy link
Member

@zoobot zoobot commented Feb 4, 2023

Changed fields to camelCase to match rest of code.

Needs #18

@tzinckgraf
Copy link
Contributor

What are you thinking for the following fields:
iso_alpha_2, iso_alpha_3, numeric_country_code, id_city_name

@zoobot
Copy link
Member Author

zoobot commented Feb 4, 2023

What are you thinking for the following fields: iso_alpha_2, iso_alpha_3, numeric_country_code, id_city_name

Country names can be quite long and not everyone agrees or spells them the same. Hoping to move to one of these for country lookup. It hasn't trickled into the FE or server code base yet though. iso_alpha_2 or iso_alpha_3?

I think id_city_name is just lowercased city. We probably don't need both especially since we are moving id to id_name.

@tzinckgraf
Copy link
Contributor

Thanks for the info on those fields. That makes sense. Do we want to make them camelCase as well?

@zoobot
Copy link
Member Author

zoobot commented Feb 6, 2023

Thanks for the info on those fields. That makes sense. Do we want to make them camelCase as well?

Yeah probably to be consistent.

@zoobot
Copy link
Member Author

zoobot commented Feb 6, 2023

I'll add another commit to make them camelCase. Will put this back in draft until that's done.

@zoobot zoobot marked this pull request as draft February 6, 2023 01:59
@zoobot zoobot marked this pull request as ready for review February 8, 2023 00:29
@zoobot
Copy link
Member Author

zoobot commented Feb 8, 2023

@tzinckgraf This is ready to go

@zoobot
Copy link
Member Author

zoobot commented Feb 8, 2023

I think it'll work better if this one goes in before #18

@tzinckgraf
Copy link
Contributor

LGTM. Thanks for making those changes.

@zoobot zoobot merged commit 9363e9b into main Feb 8, 2023
@zoobot zoobot deleted the zoobot/patch/crosswalk-fixes branch February 8, 2023 05:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sources Integration with FE and vector tiles and db
2 participants