This repository has been archived by the owner on Feb 1, 2023. It is now read-only.
Create paths that work cross-platform #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
fwextensions
commented
Apr 15, 2022
fwextensions
commented
- Use proper file URLs when dynamically importing JS files, instead of relying on absolute macOS file paths looking like parts of URLs.
- Generate paths only in config.js.
Use proper file URLs when dynamically importing JS files, instead of relying on absolute macOS file paths looking like parts of URLs. Generate paths only in config.js.
fwextensions
force-pushed
the
jdunning/fix/2022/make-cross-platform-paths
branch
from
6ed4cc3
to
b112674
Compare
|
I'm on mac and this isn't working for me. I don't think the paths to the source files are being created correctly. For example, before the import location was Here's a screenshot of what I see on this branch. And here's what it looks like for me on the main branch. |
jazhen
reviewed
Apr 29, 2022
| const country = (await import(path.join(__root, `/sources/${sourceName}`))) | ||
| .default; | ||
| const importURL = new URL(`/sources/${sourceName}`, ROOT_URL); | ||
| const country = (await import(importURL)).default; |
There was a problem hiding this comment.
I'm getting a error on this line because importURL is not a file that can't be found.
2022-04-28 22:03:34 error: CATCH Error [ERR_MODULE_NOT_FOUND]: Cannot find module '/sources/argentina.js' imported from /Users/jzhen/Dev/waterthetrees/wtt_area/bin/write-sources.js
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.