Set ADC ACQTIME to 40us #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the pinetime, the battery is connected with a 1MOhm resistor, so 3us isn't enough to measure it. The battery is the only place where the ADC is used in the pinetime, so it's ok to hardcode the new value, but it'd be better to make it configurable if contributing upstream. Fixes wasp-os/wasp-os#254 For more details see the same issue in infinitime: InfiniTimeOrg/InfiniTime#483 Signed-off-by: Francesco Gazzetta <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the pinetime, the battery is connected with a 1MOhm resistor, so 3us
isn't enough to measure it.
The battery is the only place where the ADC is used in the pinetime, so
it's ok to hardcode the new value, but it'd be better to make it
configurable if contributing upstream.
Fixes wasp-os/wasp-os#254
For more details see the same issue in infinitime:
InfiniTimeOrg/InfiniTime#483