Add ability to disable input on editor making it readonly #101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
connorwyatt
commented
Feb 27, 2017
| @@ -86,6 +86,10 @@ RE.setPlaceholder = function(placeholder) { | |||
| RE.editor.setAttribute("placeholder", placeholder); | |||
| } | |||
|
|
|||
| RE.setInputEnabled = function(inputEnabled) { | |||
| RE.editor.contentEditable = String(inputEnabled); | |||
There was a problem hiding this comment.
Needs to be set as a string: https://developer.mozilla.org/en/docs/Web/API/HTMLElement/contentEditable
|
@connorwyatt Hello, thatnk for grate PR, can I ask if you found how to make links clicable?) |
|
@frakc The easiest way I can think to make that happen is to preventDefault on the anchor click events, and then use a javascript interface provided by Android to notify the Android application. That way you can pass the url to the application. |
|
@connorwyatt |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have been trying to implement this editor for a little while and eventually found the need to make the input readonly. I'm aware that I could just switch out the editor for a web view to view the content but then you don't have consistency between the editor and the web view.
Using setFocusable, setClickable and setLongClickable mean that you can't select the text to copy it.
So instead I change the contentEditable property of the editor node in the JS.
I also removed the user-select and user-modify from the CSS as you were mixing two different methods by doing so and it would have required adding a class to override the default styles as well. I chose contenteditable as it has better browser support.
Let me know your thoughts.
P.S. It appears that it would fix issue #79 as well