`WapcHost` usage in async contexts #92

muse254 · 2024-07-28T09:03:05Z

I'd like to request for WapcHost to have another implementation that can be used in async environments by the caller.
I'm aware that execution of WebAssembly modules is single threaded.

No amount of ceremony helped sidestep this issue. Also redoing the implementation in project doesn't work because of private fields/methods accessed.

Here's what I settled for reference: https://github.com/muse254/wapc-rs/pull/1/files

The error related to this: (self holds WapcHost in it's fields)

error: future cannot be sent between threads safely
  --> harness-node/src/main.rs:50:5
   |
50 | /     pub(crate) async fn handler(
51 | |         &mut self,
52 | |         req: Request,
53 | |     ) -> HarnessResult<Response<Cursor<Vec<u8>>>> {
   | |_________________________________________________^
   |
   = note: `(dyn wapc::wapchost::traits::WebAssemblyEngineProvider + 'static)` doesn't implement `std::marker::Send`
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#future_not_send

The text was updated successfully, but these errors were encountered:

flavio · 2024-08-05T10:22:16Z

@muse254 that's super nice. This is something I wanted to implement since a long time. I'll take a look at the drafted PR during this week.

flavio · 2024-08-12T20:42:31Z

I looked into your draft PR, then I started working on the topic during the weekend.

The amount of changes to be done was massive. Everything seems to be working 😀
I’m going to open a PR in the next days

muse254 · 2024-08-13T07:17:37Z

I'll be looking forward to the next release. Thank you for the fast turnaround.

Allow waPC host to be used inside of an asynchronous runtime New structs and traits have been added: - New struct `WapcHostAsync`, this is the equivalent of `WapcHost` but for async environments. - New trait `WebAssemblyEngineProviderAsync`, this is the equivalent of `WebAssemblyEngineProvider` but for async environments. - New trait `ModuleHostAsync`, this is the equivalent of `ModuleHost` but for async environments. An async runtime has an `async` host callback function. The new type alias `HostCallbackAsync` is used to define this function. The signature of this function is slightly different from the one of the `sync` counterpart. All the input paremeters are owned types, not pointers. That's required because the function can be sent to different threads by the async runtime; introducing lifetime constraints proved to be impossible. The async support is behind a feature flag named `asyc`. This flag is enabled by default. The implementation relies on the tokio crate. Other notable changes: - The `sync` code has been moved to dedicated files to separate it from the `async` code. - The documentation now states which feature flags might be required to use a struct, type, trait, or method. Fixes wapc#92 Signed-off-by: Flavio Castelli <[email protected]>

Allow usage of wasmtime-provider inside of an asynchronous runtime. New structs and traits have been added: - New struct `WasmtimeEngineProviderAsync`, this is the equivalent of `WasmtimeEngineProvider` but for async environments. - New struct `WasmtimeEngineProviderAsyncPre`, this is the equivalent of `WasmtimeEngineProviderPre` but for async environments. - The `WasmtimeEngineProviderBuilder` has been extened to allow the creation of the new "async" objects describe above. The async support is behind a feature flag named `asyc`. This flag is enabled by default. The implementation relies on the tokio crate. Other notable changes: - The `sync` code has been moved to dedicated files to separate it from the `async` code. - The documentation now states which feature flags might be required to use a struct, type, trait, or method. - New and improved tests - Reorganized the examples, new ones have been introduced for the async counterparts - Improved `make test` target to cover all the different combination of feature flags - Fix compilation errors caused by different flag combinations Fixes wapc#92 Signed-off-by: Flavio Castelli <[email protected]>

flavio · 2024-08-13T14:34:37Z

@muse254 take a look at the linked PR and let me know what do you think about it. I've also added examples

muse254 · 2024-08-13T16:28:51Z

Hey, it looks really fleshed out. I'll be trying it out to see if I have any issues to report

muse254 · 2024-08-13T20:30:59Z

@flavio I've done some initial tests, and everything seems to be working well, at least for my use cases with WapcHostAsync and related functionality. I'm okay with the implementation as it is.
Thanks again for the quick turnaround!

muse254 · 2024-09-02T14:18:23Z

Hey, how's the review coming along. Saw that it's stale.
@flavio

flavio · 2024-09-03T08:45:42Z

@muse254 I've pinged the other waPC maintainers on #96

Allow waPC host to be used inside of an asynchronous runtime New structs and traits have been added: - New struct `WapcHostAsync`, this is the equivalent of `WapcHost` but for async environments. - New trait `WebAssemblyEngineProviderAsync`, this is the equivalent of `WebAssemblyEngineProvider` but for async environments. - New trait `ModuleHostAsync`, this is the equivalent of `ModuleHost` but for async environments. An async runtime has an `async` host callback function. The new type alias `HostCallbackAsync` is used to define this function. The signature of this function is slightly different from the one of the `sync` counterpart. All the input paremeters are owned types, not pointers. That's required because the function can be sent to different threads by the async runtime; introducing lifetime constraints proved to be impossible. The async support is behind a feature flag named `asyc`. This flag is enabled by default. The implementation relies on the tokio crate. Other notable changes: - The `sync` code has been moved to dedicated files to separate it from the `async` code. - The documentation now states which feature flags might be required to use a struct, type, trait, or method. Fixes wapc#92 Signed-off-by: Flavio Castelli <[email protected]>

Allow usage of wasmtime-provider inside of an asynchronous runtime. New structs and traits have been added: - New struct `WasmtimeEngineProviderAsync`, this is the equivalent of `WasmtimeEngineProvider` but for async environments. - New struct `WasmtimeEngineProviderAsyncPre`, this is the equivalent of `WasmtimeEngineProviderPre` but for async environments. - The `WasmtimeEngineProviderBuilder` has been extened to allow the creation of the new "async" objects describe above. The async support is behind a feature flag named `asyc`. This flag is enabled by default. The implementation relies on the tokio crate. Other notable changes: - The `sync` code has been moved to dedicated files to separate it from the `async` code. - The documentation now states which feature flags might be required to use a struct, type, trait, or method. - New and improved tests - Reorganized the examples, new ones have been introduced for the async counterparts - Improved `make test` target to cover all the different combination of feature flags - Fix compilation errors caused by different flag combinations Fixes wapc#92 Signed-off-by: Flavio Castelli <[email protected]>

Allow usage of wasmtime-provider inside of an asynchronous runtime. New structs and traits have been added: - New struct `WasmtimeEngineProviderAsync`, this is the equivalent of `WasmtimeEngineProvider` but for async environments. - New struct `WasmtimeEngineProviderAsyncPre`, this is the equivalent of `WasmtimeEngineProviderPre` but for async environments. - The `WasmtimeEngineProviderBuilder` has been extened to allow the creation of the new "async" objects describe above. The async support is behind a feature flag named `asyc`. This flag is enabled by default. The implementation relies on the tokio crate. Other notable changes: - The `sync` code has been moved to dedicated files to separate it from the `async` code. - The documentation now states which feature flags might be required to use a struct, type, trait, or method. - New and improved tests - Reorganized the examples, new ones have been introduced for the async counterparts - Improved `make test` target to cover all the different combination of feature flags - Fix compilation errors caused by different flag combinations Fixes #92 Signed-off-by: Flavio Castelli <[email protected]>

flavio · 2024-09-24T06:40:33Z

@muse254: wasmtime-provider 2.0.0 and wapc 2.0.0 are now available on crates.io 🥳

muse254 · 2024-09-24T07:07:04Z

Awesome! Can't wait to start the upgrade 🚀

flavio mentioned this issue Aug 13, 2024

Introduce async support #96

Merged

flavio closed this as completed in #96 Sep 24, 2024

flavio closed this as completed in c566681 Sep 24, 2024

muse254 mentioned this issue Sep 24, 2024

patch: official wapc support for async contexts muse254/harness#27

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

`WapcHost` usage in async contexts #92

`WapcHost` usage in async contexts #92

muse254 commented Jul 28, 2024

flavio commented Aug 5, 2024

flavio commented Aug 12, 2024

muse254 commented Aug 13, 2024

flavio commented Aug 13, 2024

muse254 commented Aug 13, 2024

muse254 commented Aug 13, 2024

muse254 commented Sep 2, 2024

flavio commented Sep 3, 2024

flavio commented Sep 24, 2024

muse254 commented Sep 24, 2024

WapcHost usage in async contexts #92

WapcHost usage in async contexts #92

Comments

muse254 commented Jul 28, 2024

flavio commented Aug 5, 2024

flavio commented Aug 12, 2024

muse254 commented Aug 13, 2024

flavio commented Aug 13, 2024

muse254 commented Aug 13, 2024

muse254 commented Aug 13, 2024

muse254 commented Sep 2, 2024

flavio commented Sep 3, 2024

flavio commented Sep 24, 2024

muse254 commented Sep 24, 2024

`WapcHost` usage in async contexts #92

`WapcHost` usage in async contexts #92