Use jaxtyping #351
Merged
Use jaxtyping #351
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #351 +/- ##
=======================================
Coverage 67.76% 67.77%
=======================================
Files 48 48
Lines 7066 7068 +2
Branches 1605 1605
=======================================
+ Hits 4788 4790 +2
- Misses 1697 1698 +1
+ Partials 581 580 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
Fast progress 🏎️ |
|
Tested example notebooks locally, didn't encounter a problem. |
waltsims
approved these changes
Mar 21, 2024
| diameter: Union[NDArray[Shape["NumElements, 2"], Float], NDArray[Shape["2, NumElements"], Float]], | ||
| amplitude: NDArray[Shape["NumElements"], Float], | ||
| phase: NDArray[Shape["NumElements"], Float], | ||
| diameter: Union[Float[np.ndarray, "NumElements 2"], Float[np.ndarray, "2 NumElements"]], |
There was a problem hiding this comment.
Should we try to be consistent about typing np.ndarray vs ndarray?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #350
Replaces
nptypingwithjaxtyping. Latter is better maintained and includes up-to-date practices. Also added an alias forbeartypein imports which should allow us to swap type checker quickly in the future, if we want to.