-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use jaxtyping #351
Use jaxtyping #351
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #351 +/- ##
=======================================
Coverage 67.76% 67.77%
=======================================
Files 48 48
Lines 7066 7068 +2
Branches 1605 1605
=======================================
+ Hits 4788 4790 +2
- Misses 1697 1698 +1
+ Partials 581 580 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Fast progress 🏎️ |
Tested example notebooks locally, didn't encounter a problem. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
Non-blocking: Should we add a test for Billy's issue?
diameter: Union[NDArray[Shape["NumElements, 2"], Float], NDArray[Shape["2, NumElements"], Float]], | ||
amplitude: NDArray[Shape["NumElements"], Float], | ||
phase: NDArray[Shape["NumElements"], Float], | ||
diameter: Union[Float[np.ndarray, "NumElements 2"], Float[np.ndarray, "2 NumElements"]], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we try to be consistent about typing np.ndarray vs ndarray?
Closes #350
Replaces
nptyping
withjaxtyping
. Latter is better maintained and includes up-to-date practices. Also added an alias forbeartype
in imports which should allow us to swap type checker quickly in the future, if we want to.