Refactor dunder init #349
Refactor dunder init #349
Conversation
There is some circular logic with the binary lists and the urls etc...
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #349 +/- ##
=======================================
Coverage 68.00% 68.00%
=======================================
Files 48 48
Lines 7066 7061 -5
Branches 1605 1605
=======================================
- Hits 4805 4802 -3
+ Misses 1687 1686 -1
+ Partials 574 573 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
| # Constants and Configurations | ||
| URL_BASE = "https://github.com/waltsims/" | ||
| BINARY_VERSION = "v1.3.0" | ||
| PREFIX = f"{URL_BASE}kspaceFirstOrder-{{}}-{{}}/releases/download/{BINARY_VERSION}/" |
There was a problem hiding this comment.
Why nested curly braces ({{}})?
There was a problem hiding this comment.
Not sure if it's good smell or where I got it from but allows you to evaluate the f-string twice. The first evaluation leaves the curly brackets in the f-string for the second evaluation step.
There was a problem hiding this comment.
Hmm interesting, I never saw double braces in f-strings before and not sure if this is a good convention to follow or not.
|
Thanks for the comments! I've revisited things this evening. Have another look when you have a second. |
No description provided.