-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove legacy mode from write attributes #289
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #289 +/- ##
==========================================
- Coverage 66.51% 66.45% -0.07%
==========================================
Files 48 48
Lines 6998 6982 -16
Branches 1583 1579 -4
==========================================
- Hits 4655 4640 -15
Misses 1728 1728
+ Partials 615 614 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice. Looks good to me!
As I mentioned in #291 it would be good to document how to create the .json files from potential new kWave releases. Perhaps we can add those instructions there.
@faridyagubbayli please look into this and re-open a PR. |
Closes #253