Add custom element #212
Merged
Add custom element #212
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
waltsims
requested changes
Sep 28, 2023
|
I've made the requested changes, this PR is ready be reviewed. |
Also test that error is correctly raised
|
I believe this now matches the logic from MATLAB and passes the CI when testing that the ValueError is raised. I think there is a logic error in k-wave MATLAB with the use of |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sorry I had to put this down temporarily and focus on a deadline but I've added the 2d and 3d custom element instances to both collect_kWaveArray.m and kWaveArray_test.py. The test was a pass on my system.