Python implementation of kWaveArray
& get_off_grid_points(...)
#168
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #156
Closes #130
Migrates
kWaveArray
class,get_off_grid_points(...)
functions and related code entities to Python. Also, introduces a new test case for comparing the outputs of the Python implementation against the Matlab implementation.Note: some functions used in
kWaveArray
are not available in the Python version of thekWave
yet. Testing logic was designed to skip the invocation of unavailable functions. We should look into this as future work.Complete List of Changes
tol_star
andfind_closest
functions underconversions.py
kWaveArray
class and its methodstrim_cart_points
functioncollect_kWaveArray.m
with a new test casekWaveArray_test.py
to ensure outputs of the Python version are equal or very similar to the Matlab versionkWaveArray
comparator to check if the states of thekWaveArray
object in Python and Matlab tests are equal