Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python implementation of kWaveArray & get_off_grid_points(...) #168

Merged
merged 7 commits into from
Jul 17, 2023

Conversation

faridyagubbayli
Copy link
Collaborator

@faridyagubbayli faridyagubbayli commented Jul 6, 2023

Closes #156
Closes #130

Migrates kWaveArray class, get_off_grid_points(...) functions and related code entities to Python. Also, introduces a new test case for comparing the outputs of the Python implementation against the Matlab implementation.

Note: some functions used in kWaveArray are not available in the Python version of the kWave yet. Testing logic was designed to skip the invocation of unavailable functions. We should look into this as future work.

Complete List of Changes

  • Added tol_star and find_closest functions under conversions.py
  • Added kWaveArray class and its methods
  • Bug fix in trim_cart_points function
  • Updated collect_kWaveArray.m with a new test case
  • Added kWaveArray_test.py to ensure outputs of the Python version are equal or very similar to the Matlab version
  • Added kWaveArray comparator to check if the states of the kWaveArray object in Python and Matlab tests are equal

@faridyagubbayli faridyagubbayli changed the title Python implementation of kWaveArray Python implementation of kWaveArray & get_off_grid_points(...) Jul 16, 2023
Copy link
Owner

@waltsims waltsims left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great!

@waltsims waltsims merged commit ac45b70 into master Jul 17, 2023
12 checks passed
@waltsims waltsims deleted the kwave-array branch July 17, 2023 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

v1.4.0 [NewFunction] kWaveArray v1.4.0 [NewFunction] offGridPoints
2 participants