Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python implementation of trimCartPoints #134

Merged
merged 3 commits into from
May 25, 2023
Merged

Conversation

faridyagubbayli
Copy link
Collaborator

Closes #133

Adds Python implementation of the trimCartPoints function (introduced in kWave 1.4) together with test cases.

Copy link
Owner

@waltsims waltsims left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Copy link
Owner

@waltsims waltsims left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

@faridyagubbayli faridyagubbayli merged commit 152bf23 into master May 25, 2023
@faridyagubbayli faridyagubbayli deleted the new/trim-cart-points branch May 25, 2023 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

v1.4.0 [NewFunction] trimCartPoints
2 participants