Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove session-based redirection #7140

Merged
merged 4 commits into from
Jan 2, 2024

Conversation

yguedidi
Copy link
Contributor

@yguedidi yguedidi commented Dec 25, 2023

fixes #6944

easier to review commit by commit 😉

@yguedidi yguedidi marked this pull request as draft December 25, 2023 20:44
@yguedidi yguedidi force-pushed the remove-session-based-redirection branch from 7b7c1e8 to 5707a43 Compare December 25, 2023 20:49
@yguedidi yguedidi changed the base branch from master to 2.6 December 25, 2023 20:50
@yguedidi yguedidi force-pushed the remove-session-based-redirection branch from 5707a43 to 8b5dc5a Compare December 25, 2023 20:50
@yguedidi yguedidi added this to the 2.6.8 milestone Dec 25, 2023
@yguedidi yguedidi force-pushed the remove-session-based-redirection branch from 8b5dc5a to 817c3eb Compare December 25, 2023 22:00
@yguedidi yguedidi marked this pull request as ready for review December 25, 2023 22:04
@yguedidi yguedidi force-pushed the remove-session-based-redirection branch from 817c3eb to bcb9980 Compare December 27, 2023 18:28
@j0k3r
Copy link
Member

j0k3r commented Dec 27, 2023

How is a link generated with the redirect attribute in it? I guess it's displayed in the URl? Won't this be too ugly?

@yguedidi
Copy link
Contributor Author

The redirect GET parameter is indeed part of the URL, but it's not likely to be seen by users, because the links are actions that will redirect right after saving, so the parameter will not appear in the address bar as the user will end on the final URL, without the redirect param

@yguedidi yguedidi force-pushed the remove-session-based-redirection branch 2 times, most recently from 3776de3 to fcd1d30 Compare December 28, 2023 20:28
@yguedidi yguedidi force-pushed the remove-session-based-redirection branch from fcd1d30 to 9bef459 Compare December 28, 2023 20:52
@yguedidi yguedidi requested review from j0k3r, nicosomb and Kdecherf and removed request for j0k3r, nicosomb and Kdecherf December 28, 2023 21:30
@yguedidi yguedidi mentioned this pull request Jan 2, 2024
6 tasks
Copy link
Member

@Kdecherf Kdecherf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

It should be noted that redirect can be a misleading term here: depending on the value of config_action_mark_as_read the redirect path may not be used.

@yguedidi yguedidi merged commit 5e89fc2 into wallabag:2.6 Jan 2, 2024
19 checks passed
@yguedidi yguedidi deleted the remove-session-based-redirection branch January 2, 2024 22:39
@yguedidi
Copy link
Contributor Author

yguedidi commented Jan 2, 2024

It should be noted that redirect can be a misleading term here: depending on the value of config_action_mark_as_read the redirect path may not be used.

@Kdecherf you're right! merging to unblock the 2.6.8 release, could be renamed later, if we find a better name 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Session-based redirect may redirect to incorrect pages
3 participants