Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Param sameSite in the $response->cookie() should be a string #1010

Closed
Qclanton opened this issue Feb 17, 2024 · 1 comment
Closed

Param sameSite in the $response->cookie() should be a string #1010

Qclanton opened this issue Feb 17, 2024 · 1 comment

Comments

@Qclanton
Copy link

Qclanton commented Feb 17, 2024 •
edited
Loading

According to documentation, param "SameSite" for cookie can take values "None", "Strict", or "Lax" (documentation) but \Workerman\Protocols\Http\Response::cookie() expects boolean value for this param
walkor added a commit that referenced this issue Feb 19, 2024
@walkor
fix sameSite for cookie #1010
3b7f39c
@walkor
Copy link
Owner

walkor commented Feb 22, 2024

Fixed

@walkor walkor closed this as completed Feb 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Qclanton @walkor