-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update go minimum version #3285
Conversation
V2.7.1 Go 1.20 is now the minimum supported Go version.
WalkthroughThis update signifies a significant advancement in the Wails development environment requirements, notably shifting the Go and Node version prerequisites. The minimum Go version has been raised from 1.18 to 1.20, ensuring users can leverage the latest enhancements and security features. Concurrently, the Node version requirement remains stable at 15+, ensuring compatibility without mandating an update. Changes
Related issues
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review Status
Actionable comments generated: 0
Configuration used: CodeRabbit UI
Files selected for processing (1)
- website/versioned_docs/version-v2.8.0/gettingstarted/installation.mdx (1 hunks)
Additional comments: 4
website/versioned_docs/version-v2.8.0/gettingstarted/installation.mdx (4)
- 18-18: The update of the Go version requirement from 1.18+ to 1.20+ is correctly documented. This change aligns with the PR's objective to update the minimum supported version of Go for the project. It's important to ensure that all references to Go versions in the documentation and code comments are updated to reflect this change.
- 18-18: The Node version requirement remains at 15+, as mentioned in the PR summary. This documentation correctly reflects the current requirement, indicating no change in the Node version requirement. It's good practice to periodically review these requirements to ensure they align with the latest versions and project needs.
- 18-18: While the Go version requirement update is correctly documented, it's also essential to ensure that any downstream dependencies or project components that rely on specific Go features or behavior are tested and verified to work with Go 1.20+. This includes any build scripts, CI/CD pipelines, or Dockerfiles that specify a Go version.
- 18-18: The documentation mentions running
wails doctor
to check for correct dependencies. Given the update to the Go version requirement, it's crucial to ensure that thewails doctor
command itself and any related diagnostic tools are updated to recognize and validate the new Go version requirement. This helps maintain a consistent and reliable setup experience for users.
Thanks for this, would it be also possible for you to update the build constraints here |
Very honored |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review Status
Actionable comments generated: 0
Configuration used: CodeRabbit UI
Files selected for processing (1)
- v2/internal/goversion/min.go (1 hunks)
Additional comments: 1
v2/internal/goversion/min.go (1)
- 3-3: The update of the
MinRequirement
constant to "1.20" correctly reflects the PR's objective to support Go 1.20 as the minimum version. Ensure that:
- All project dependencies are compatible with Go 1.20.
- The documentation, especially the changelog and installation guides, is updated to reflect this change.
- The project has been thoroughly tested on Go 1.20 across Windows, macOS, and Linux to ensure full functionality.
Thanks for this! I see you've updated the docs for v2.8, which will eventually be deleted. Would it be possible to update |
ok |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review Status
Actionable comments generated: 0
Configuration used: CodeRabbit UI
Files selected for processing (1)
- website/docs/gettingstarted/installation.mdx (1 hunks)
Files skipped from review due to trivial changes (1)
- website/docs/gettingstarted/installation.mdx
Thanks 🙏 Please could you add an entry to the changelog located at |
It already exists. |
The PR contains an update to a versioned doc. We will lose that eventually 👍 |
V2.7.1 Go 1.20 is now the minimum supported Go version.
Description
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Fixes # (issue)
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration using
wails doctor
.Test Configuration
Please paste the output of
wails doctor
. If you are unable to run this command, please describe your environment in as much detail as possible.Checklist:
website/src/pages/changelog.mdx
with details of this PRSummary by CodeRabbit