Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update npm and docker package names for dnf package manager #2790

Merged
merged 2 commits into from
Jul 24, 2023
Merged

chore: update npm and docker package names for dnf package manager #2790

merged 2 commits into from
Jul 24, 2023

Conversation

aranggitoar
Copy link
Contributor

@aranggitoar aranggitoar commented Jul 23, 2023

Description

This pull request added the current package names for NPM and Docker for Fedora 38.

Fixes #2638

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration using wails doctor.

  • Windows
  • macOS
  • Linux

Test Configuration

Please paste the output of wails doctor. If you are unable to run this command, please describe your environment in as much detail as possible.

image

Checklist:

  • I have updated website/src/pages/changelog.mdx with details of this PR
  • My code follows the general coding style of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@aranggitoar aranggitoar changed the title chore: update package names for dnf package manager chore: update npm and docker package names for dnf package manager Jul 23, 2023
@leaanthony
Copy link
Member

Thanks 🙏 Please could you add an entry to the changelog located at website/src/pages/changelog.mdx?

@aranggitoar
Copy link
Contributor Author

You're welcome.

Would the entry I just commited be enough?

@leaanthony
Copy link
Member

Perfect! Thank you 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Linux] NPM installed and working but "not found" in wails doctor
2 participants