Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v2 templates] Add explicit style import #2721

Merged
merged 2 commits into from
Jul 10, 2023
Merged

[v2 templates] Add explicit style import #2721

merged 2 commits into from
Jul 10, 2023

Conversation

leaanthony
Copy link
Member

Description

Templates have been updated to include an explicit import for style.css.

Fixes #2705

@stffabi
Copy link
Collaborator

stffabi commented Jun 12, 2023 •
edited
Loading

LGTM 👍

Maybe we should also remove the old <link href="./src/style.css" rel="stylesheet"> for those templates?

@stffabi
Copy link
Collaborator

stffabi commented Jul 10, 2023

@leaanthony can we merge this? I think we should also remove the normal link hrefs.

@leaanthony leaanthony enabled auto-merge (squash) July 10, 2023 11:03
@leaanthony leaanthony requested a review from stffabi July 10, 2023 11:03
@leaanthony
Copy link
Member Author

Sorry - slipped the net. Approve and it'll merge 👍

stffabi
stffabi approved these changes Jul 10, 2023
View reviewed changes
Copy link
Collaborator

@stffabi stffabi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks 👍

@leaanthony leaanthony merged commit 61f7b10 into master Jul 10, 2023
2 checks passed
@leaanthony leaanthony deleted the v2/css-import-fix branch July 10, 2023 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stffabi stffabi stffabi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[linux, dev] CSS included with "link"-tag do not work
2 participants
@leaanthony @stffabi