v2 linux: SecondInstanceData.WorkingDirectory not initialized

[Vovan-VE]

Description

v2.7 instoduced SingleInstanceLock, but on linux the SecondInstanceData.WorkingDirectory is always empty:

wails/v2/internal/frontend/desktop/linux/single_instance.go

Lines 55 to 57 in dc5f0b6

	data := options.SecondInstanceData{
	Args: os.Args[1:],
	}

To Reproduce

func (a *App) secondInstance(data options.SecondInstanceData) {
	runtime.LogInfof(a.ctx, "%#v", data)
}

$ ./build/bin/linux-app ../foo.txt

Expected behaviour

INF | options.SecondInstanceData{Args:[]string{"../foo.txt"}, WorkingDirectory:"/abs/path"}

Screenshots

INF | options.SecondInstanceData{Args:[]string{"../foo.txt"}, WorkingDirectory:""}

Attempted Fixes

No response

System Details

# Wails
Version         | v2.7.1
Package Manager | apt   

# System
┌──────────────────────────────────────────────────────────────────────────────────┐
| OS           | Ubuntu                                                            |
| Version      | 22.04                                                             |
| ID           | ubuntu                                                            |
| Go Version   | go1.20.5                                                          |
| Platform     | linux                                                             |
| Architecture | amd64                                                             |
| CPU          | AMD Ryzen ...
| GPU          | unknown (Advanced Micro Devices, Inc. [AMD/ATI]) - Driver: amdgpu |
| Memory       | ..GB                                                              |
└──────────────────────────────────────────────────────────────────────────────────┘

# Dependencies
┌──────────────────────────────────────────────────────────────────────────┐
| Dependency | Package Name          | Status    | Version                 |
| *docker    | docker.io             | Available | 24.0.5-0ubuntu1~22.04.1 |
| gcc        | build-essential       | Installed | 12.9ubuntu3             |
| libgtk-3   | libgtk-3-dev          | Installed | 3.24.33-1ubuntu2        |
| libwebkit  | libwebkit2gtk-4.0-dev | Installed | 2.42.3-0ubuntu0.22.04.1 |
| npm        | npm                   | Installed | 9.5.1                   |
| *nsis      | nsis                  | Installed | v3.08-2                 |
| pkg-config | pkg-config            | Installed | 0.29.2                  |
└──────────────────────── * - Optional Dependency ─────────────────────────┘

# Diagnosis
Optional package(s) installation details: 
  - docker: sudo apt install docker.io

 SUCCESS  Your system is ready for Wails development!

Additional context

No response

[Vovan-VE]

It's inconsistent or incomplete. Looks same for windows:

wails/v2/internal/frontend/desktop/windows/single_instance.go

Lines 51 to 54 in dc5f0b6

	data := options.SecondInstanceData{
	Args: os.Args[1:],
	}
	serialized, _ := json.Marshal(data)

but different for darwin:

wails/v2/internal/frontend/desktop/darwin/single_instance.go

Lines 35 to 40 in dc5f0b6

	data, err := options.NewSecondInstanceData()
	if err != nil {
	return
	}
	serialized, err := json.Marshal(data)

wails/v2/pkg/options/options.go

Lines 183 to 194 in dc5f0b6

	func NewSecondInstanceData() (*SecondInstanceData, error) {
	ex, err := os.Executable()
	if err != nil {
	return nil, err
	}
	workingDirectory := filepath.Dir(ex)
	return &SecondInstanceData{
	Args: os.Args[1:],
	WorkingDirectory: workingDirectory,
	}, nil
	}

Using dir of executable in common case is not equal to CWD.

[leaanthony]

@APshenkin - is this usage correct for this feature? Any assistance would be appreciated 🙏

[APshenkin]

Will take a look