Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there - I took a crack at updating this Lua module to work with OpenSSL 3.0.0 (issue #195), by trying to make the EVP_KDF-emulating functions closer match the OpenSSL 3.0.0 signatures.
I'm very welcome to feedback on this, there's one area where I'm not sure if I'm doing the right thing or not -
Previously, when using EVP_KDF_ctrl with
EVP_KDF_CTRL_SET_MD
- that uses some opaque message digest type. It looks like in OpenSSL 3.0.0, if youset the digest they expect a printable string. I'm unsure ifmk_checkdigest
is just taking a regular printable string and converting it to that custom type?I'm also not super-stoked about OpenSSL adding this new
OSSL_PARAM
type and requiring its usage - this resulted in having a whole lot of#if
directives in thekdf_derive
function. The only other way I see getting around that would be actually defining theOSSL_PARAM
type and writing thoseconstruct
functions, then write a replacementEVP_KDF_CTX_set_params
function that iterates through the params and callsEVP_KDF_ctrl
with the appropriate arguments.There's a good number of deprecation warnings, but as far as I can tell it works correctly. But could/should probably get more eyes on it and tested.