Clean up auto_orient logic
#138
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move away from bespoke logic and rely on `ImageOps.exif_transpose()`. This method works much better than our own as it also supports reading XMP metadata instead of just EXIF. In addition, it also removes the orientation metadata from the transposed image. This method was added in Pillow 6.0.0. See: https://github.com/python-pillow/Pillow/blob/28c173f8d4767c7f6dd22dc840117fe641f4d3ee/docs/releasenotes/6.0.0.rst#added-imageopsexif_transpose This fixes #137 in the process by removing stale orientation metadata.
|
Removing code feels so good 😛 |
Stormheg
commented
Nov 19, 2023
Comment on lines
+32
to
+36
| def _PIL_ImageOps(): | ||
| import PIL.ImageOps | ||
|
|
||
| return PIL.ImageOps | ||
|
|
There was a problem hiding this comment.
I'm following the same pattern as the code above. Not sure if it is needed though, I assume the indirection is to defer loading large modules? Not sure if that applies to PIL.ImageOps
To prove that orientation metadata is removed, as that is part of the expected behaviour now.
7ff4433
to
26dfb17
Compare
|
As it turns out, a very similar change is proposed in #136. Closing this in favour of that PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move away from bespoke logic and rely on
ImageOps.exif_transpose(). This method works much better than our own as it also supports reading XMP metadata instead of just EXIF.In addition, it also removes the orientation metadata from the transposed image.
This method was added in Pillow 6.0.0.
See: https://github.com/python-pillow/Pillow/blob/28c173f8d4767c7f6dd22dc840117fe641f4d3ee/docs/releasenotes/6.0.0.rst#added-imageopsexif_transpose
This fixes #137 in the process by removing stale orientation metadata.