Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix cropping of SVGs #113

Closed
wants to merge 18 commits into from
Closed

Fix cropping of SVGs #113

wants to merge 18 commits into from

Commits on Jun 18, 2023

  1. Remove redundant translation in SVG crop, add tests with SVG files

    @jams2
    jams2 committed Jun 18, 2023
    Configuration menu
    Copy the full SHA
    7d32e6d View commit details
    Browse the repository at this point in the history

  2. Account for non-zero viewBox minX/minY when cropping SVGs

    @jams2
    jams2 committed Jun 18, 2023
    Configuration menu
    Copy the full SHA
    bf5397f View commit details
    Browse the repository at this point in the history

  3. Don't list test SVGs explicitly in test case

    @jams2
    jams2 committed Jun 18, 2023
    Configuration menu
    Copy the full SHA
    4113f65 View commit details
    Browse the repository at this point in the history

Commits on Jun 19, 2023

  1. Use symlinks rather than duplicating test SVGs

    @jams2
    jams2 committed Jun 19, 2023
    Configuration menu
    Copy the full SHA
    f23f884 View commit details
    Browse the repository at this point in the history

  2. Add SVG tests for cropping 2x scaled viewbox

    @jams2
    jams2 committed Jun 19, 2023
    Configuration menu
    Copy the full SHA
    bb7f9d0 View commit details
    Browse the repository at this point in the history

  3. Add test SVG for issue wagtail#112

    @jams2
    jams2 committed Jun 19, 2023
    Configuration menu
    Copy the full SHA
    a5fe081 View commit details
    Browse the repository at this point in the history

  4. Add tests for xMin/xMax meet

    @jams2
    jams2 committed Jun 19, 2023
    Configuration menu
    Copy the full SHA
    089cce5 View commit details
    Browse the repository at this point in the history

  5. Update snapshots to computed output

    @jams2
    jams2 committed Jun 19, 2023
    Configuration menu
    Copy the full SHA
    8c932e4 View commit details
    Browse the repository at this point in the history

  6. Add tests for preserveAspectRatio="none"

    @jams2
    jams2 committed Jun 19, 2023
    Configuration menu
    Copy the full SHA
    dbf2133 View commit details
    Browse the repository at this point in the history

Commits on Jun 20, 2023

  1. Add tests for preserveAspectRatio "none"/"xMidYMid slice"

    @jams2
    jams2 committed Jun 20, 2023
    Configuration menu
    Copy the full SHA
    a051103 View commit details
    Browse the repository at this point in the history

  2. Make symlinks relative

    @jams2
    jams2 committed Jun 20, 2023
    Configuration menu
    Copy the full SHA
    9992559 View commit details
    Browse the repository at this point in the history

  3. Make sure translation is applied to input rect unconditionally 

    This was removed when the transform_rect_to_user_space function was
removed.
    @jams2
    jams2 committed Jun 20, 2023
    Configuration menu
    Copy the full SHA
    f3bf392 View commit details
    Browse the repository at this point in the history

Commits on Jun 21, 2023

  1. Add more tests for xMidYMid meet/slice

    @jams2
    jams2 committed Jun 21, 2023
    Configuration menu
    Copy the full SHA
    3bb5b30 View commit details
    Browse the repository at this point in the history

Commits on Jun 22, 2023

  1. Add more test SVGs

    @jams2
    jams2 committed Jun 22, 2023
    Configuration menu
    Copy the full SHA
    3afefa5 View commit details
    Browse the repository at this point in the history

  2. Remove old SVG cropping tests 

    The new tests with fixtures cover the same cases
    @jams2
    jams2 committed Jun 22, 2023
    Configuration menu
    Copy the full SHA
    7227e22 View commit details
    Browse the repository at this point in the history

  3. Flip sign of translation factor so it can be added rather... 

    ...than subtracted from the original bounding rect. This seems to be
more conventional.
    @jams2
    jams2 committed Jun 22, 2023
    Configuration menu
    Copy the full SHA
    7c772c9 View commit details
    Browse the repository at this point in the history

  4. Add tests for xMinYMin meet

    @jams2
    jams2 committed Jun 22, 2023
    Configuration menu
    Copy the full SHA
    6d2a768 View commit details
    Browse the repository at this point in the history

  5. Clarify comment

    @jams2
    jams2 committed Jun 22, 2023
    Configuration menu
    Copy the full SHA
    c46f95f View commit details
    Browse the repository at this point in the history