Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat: add ctrl-z support #447

Merged
merged 5 commits into from
Jul 6, 2023
Merged

Feat: add ctrl-z support #447

merged 5 commits into from
Jul 6, 2023

Conversation

yurenchen000
Copy link
Contributor

@yurenchen000 yurenchen000 commented May 2, 2023 •
edited
Loading

implement feat-req #297

Changes:

  • update gocui to v1.1.0 // in order to suspend/resume
  • fix layer cursor move // adapt for gocui v1.x
  • add ctrl+z support

only tested on ubuntu22, build with go1.18

@tonymet
Copy link

tonymet commented May 2, 2023 •
edited
Loading

i pulled your branch, built, tested and it works for me.

BUILD

$ make build

RUN / TEST

$ ./dist/dive_linux_amd64/dive alpine

RESULTS

  • ctrl-z works ✅
  • fg works ✅

TEST Environment

$ git log -1
6032f68 - (HEAD, yurenchen0000/feat-ctrl-z) feat: add ctrl+z support (17 hours ago) <chen>

$ go version
go version go1.17.7 linux/amd64


$ cat /etc/os-release
NAME="Amazon Linux"
VERSION="2"
ID="amzn"
ID_LIKE="centos rhel fedora"
VERSION_ID="2"
PRETTY_NAME="Amazon Linux 2"
ANSI_COLOR="0;33"
CPE_NAME="cpe:2.3:o:amazon:amazon_linux:2"
HOME_URL="https://amazonlinux.com/"

$ uname -a 
Linux ip-172-31-38-22.us-west-2.compute.internal 4.14.305-227.531.amzn2.x86_64 #1 SMP Tue Feb 14 09:55:28 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

This was referenced Jun 5, 2023
Closed
Open
wagoodman
wagoodman previously approved these changes Jul 6, 2023
View reviewed changes
Copy link
Owner

@wagoodman wagoodman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

slick! Thanks for adding job control (and for the cursor fix) 🙌

@wagoodman wagoodman merged commit a70b7ac into wagoodman:master Jul 6, 2023
@wagoodman wagoodman linked an issue Jul 6, 2023 that may be closed by this pull request
Support Ctrl-Z for job control. #297
Closed
@mark2185 mark2185 mentioned this pull request Jul 7, 2023
Merged
This was referenced Jul 7, 2023
Merged
Merged
@mark2185 mark2185 mentioned this pull request Sep 6, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wagoodman wagoodman wagoodman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support Ctrl-Z for job control.
3 participants
@yurenchen000 @tonymet @wagoodman