forked from denoland/deno
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
feat(core): initialize SQLite off-main-thread (denoland#18401)
This gets SQLite off the flamegraph and reduces initialization time by somewhere between 0.2ms and 0.5ms. In addition, I took the opportunity to move all the cache management code to a single place and reduce duplication. While the PR has a net gain of lines, much of that is just being a bit more deliberate with how we're recovering from errors. The existing caches had various policies for dealing with cache corruption, so I've unified them and tried to isolate the decisions we make for recovery in a single place (see `open_connection` in `CacheDB`). The policy I chose was: 1. Retry twice to open on-disk caches 2. If that fails, try to delete the file and recreate it on-disk 3. If we fail to delete the file or re-create a new cache, use a fallback strategy that can be chosen per-cache: InMemory (temporary cache for the process run), BlackHole (ignore writes, return empty reads), or Error (fail on every operation). The caches all use the same general code now, and share the cache failure recovery policy. In addition, it cleans up a TODO in the `NodeAnalysisCache`.
- Loading branch information
Showing
17 changed files
with
999 additions
and
622 deletions.
There are no files selected for viewing
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,75 @@ | ||
// Copyright 2018-2023 the Deno authors. All rights reserved. MIT license. | ||
|
||
use std::path::PathBuf; | ||
use std::sync::Arc; | ||
|
||
use once_cell::sync::OnceCell; | ||
|
||
use super::cache_db::CacheDB; | ||
use super::cache_db::CacheDBConfiguration; | ||
use super::check::TYPE_CHECK_CACHE_DB; | ||
use super::incremental::INCREMENTAL_CACHE_DB; | ||
use super::node::NODE_ANALYSIS_CACHE_DB; | ||
use super::parsed_source::PARSED_SOURCE_CACHE_DB; | ||
use super::DenoDir; | ||
|
||
#[derive(Clone, Default)] | ||
pub struct Caches { | ||
fmt_incremental_cache_db: Arc<OnceCell<CacheDB>>, | ||
lint_incremental_cache_db: Arc<OnceCell<CacheDB>>, | ||
dep_analysis_db: Arc<OnceCell<CacheDB>>, | ||
node_analysis_db: Arc<OnceCell<CacheDB>>, | ||
type_checking_cache_db: Arc<OnceCell<CacheDB>>, | ||
} | ||
|
||
impl Caches { | ||
fn make_db( | ||
cell: &Arc<OnceCell<CacheDB>>, | ||
config: &'static CacheDBConfiguration, | ||
path: PathBuf, | ||
) -> CacheDB { | ||
cell | ||
.get_or_init(|| CacheDB::from_path(config, path, crate::version::deno())) | ||
.clone() | ||
} | ||
|
||
pub fn fmt_incremental_cache_db(&self, dir: &DenoDir) -> CacheDB { | ||
Self::make_db( | ||
&self.fmt_incremental_cache_db, | ||
&INCREMENTAL_CACHE_DB, | ||
dir.fmt_incremental_cache_db_file_path(), | ||
) | ||
} | ||
|
||
pub fn lint_incremental_cache_db(&self, dir: &DenoDir) -> CacheDB { | ||
Self::make_db( | ||
&self.lint_incremental_cache_db, | ||
&INCREMENTAL_CACHE_DB, | ||
dir.lint_incremental_cache_db_file_path(), | ||
) | ||
} | ||
|
||
pub fn dep_analysis_db(&self, dir: &DenoDir) -> CacheDB { | ||
Self::make_db( | ||
&self.dep_analysis_db, | ||
&PARSED_SOURCE_CACHE_DB, | ||
dir.dep_analysis_db_file_path(), | ||
) | ||
} | ||
|
||
pub fn node_analysis_db(&self, dir: &DenoDir) -> CacheDB { | ||
Self::make_db( | ||
&self.node_analysis_db, | ||
&NODE_ANALYSIS_CACHE_DB, | ||
dir.node_analysis_db_file_path(), | ||
) | ||
} | ||
|
||
pub fn type_checking_cache_db(&self, dir: &DenoDir) -> CacheDB { | ||
Self::make_db( | ||
&self.type_checking_cache_db, | ||
&TYPE_CHECK_CACHE_DB, | ||
dir.type_checking_cache_db_file_path(), | ||
) | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.